[GPU] Consider the node which is shape_of subgraph and ocl_impl in update_shape() #27551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeonbok
reviewed
Nov 14, 2024
| @@ -429,7 +429,8 @@ void primitive_inst::update_shape() { | |||
| continue; | |||
| } | |||
|
|
|||
| if (!get_node().is_type<shape_of>() && !dep->get_node().is_in_shape_of_subgraph()) { | |||
| if (!get_node().is_type<shape_of>() && | |||
| !(dep->get_node().is_in_shape_of_subgraph() && dep->get_node().get_selected_impl()->is_cpu())) { | |||
There was a problem hiding this comment.
In this case, I think we can just replace it with
!get_node().is_type<shape_of>() && !dep->get_node().get_selected_impl()->is_cpu()
Because if the dep is cpu, the execution is already finished.
There was a problem hiding this comment.
Updated! Thanks!
|
Please add a unittest |
wilson-seok
force-pushed
the
fix_update_shape_for_shapeof_subgraph_ocl_impl
branch
from
57eb530
to
2c364ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: